txframe blobify and persist#4220
Merged
Merged
Conversation
tersec
reviewed
May 8, 2026
tersec
reviewed
May 8, 2026
tersec
reviewed
May 8, 2026
tersec
reviewed
May 8, 2026
tersec
reviewed
May 8, 2026
tersec
reviewed
May 8, 2026
tersec
reviewed
May 8, 2026
tersec
reviewed
May 8, 2026
Contributor
|
Is this diff cache pruned somewhere when base updates? |
Contributor
Author
Not yet, but will |
…int detour) blob.len widened to uint64 for the bounds comparisons aLen + 4 + 4 and kOff + 4 + kLen can't overflow uint64 int(...) only at the final blob.toOpenArray indexing — and by then the bounds check has guaranteed the value fits in int (since it's at most blob.len, itself an int)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opens up interface for us to persist
txFrameinto the database, so that we don't need to re-process the blocks again. Further it will be used to extend the DAG implementationFor now reduces the overhead for
FcState, i.e fixes #3244Size Estimates
For a typical Ethereum mainnet block (~200 transactions):
Practical range:
A cache window of 64 recent frames requires roughly 40 MB total KVT storage.